Skip to content

Added find_api_root() to standardize URL building-blocks.#7556

Merged
dralley merged 1 commit intopulp:mainfrom
ggainey:api_root_madness
Apr 10, 2026
Merged

Added find_api_root() to standardize URL building-blocks.#7556
dralley merged 1 commit intopulp:mainfrom
ggainey:api_root_madness

Conversation

@ggainey
Copy link
Copy Markdown
Contributor

@ggainey ggainey commented Apr 6, 2026

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@ggainey ggainey force-pushed the api_root_madness branch from e07273f to 61acb5c Compare April 6, 2026 19:00
@ggainey ggainey marked this pull request as draft April 6, 2026 20:03
@ggainey
Copy link
Copy Markdown
Contributor Author

ggainey commented Apr 6, 2026

Drafting for now - looks like REWRITE_HEADER isn't right, yet

@ggainey ggainey force-pushed the api_root_madness branch from 61acb5c to 8b97f42 Compare April 9, 2026 21:27
@ggainey
Copy link
Copy Markdown
Contributor Author

ggainey commented Apr 10, 2026

The current azure failure doesn't seem to be related to the changes?

@ggainey ggainey marked this pull request as ready for review April 10, 2026 03:13
@ggainey ggainey requested a review from mdellweg April 10, 2026 03:13
@dralley
Copy link
Copy Markdown
Contributor

dralley commented Apr 10, 2026

It's not, it's a race condition in the replication test that I was looking into the other day

@ggainey ggainey requested a review from dralley April 10, 2026 12:27
mdellweg
mdellweg previously approved these changes Apr 10, 2026
@ggainey ggainey force-pushed the api_root_madness branch 3 times, most recently from 5852f35 to bcc5fd6 Compare April 10, 2026 20:02
@dralley dralley enabled auto-merge (rebase) April 10, 2026 20:25
@dralley dralley merged commit ff7a190 into pulp:main Apr 10, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants